Skip to content

[xess xmx] Don't hide Intel GPUs when XeSS is provided by Proton - #5992

Open
damian-tomczak-intel wants to merge 6 commits into
doitsujin:masterfrom
damian-tomczak-intel:xess-release
Open

damian-tomczak-intel wants to merge 6 commits into
doitsujin:masterfrom
damian-tomczak-intel:xess-release

Conversation

@damian-tomczak-intel

Copy link
Copy Markdown
Contributor

Skips the XeSS vendor workaround, which hides Intel GPUs from games with a libxess.dll older than 2.0.2.68, when XeSS is provided by Proton. Proton's libxess.dll is a Wine builtin forwarding to the Linux XeSS library, it has no version resource, so the check always failed and the Intel GPU was hidden.

The workaround is now also decided when adapters are enumerated instead of when the DXGI options are created, since games can load libxess.dll later. A positive decision is cached so later adapter queries stay consistent, and the decision is logged. dxgi.hideIntelGpu still overrides it.

Part of the [XeSS XMX] series, see the comment below for the other PRs.

@damian-tomczak-intel damian-tomczak-intel changed the title xess xmx: Don't hide Intel GPUs when XeSS is provided by Proton [xess xmx] Don't hide Intel GPUs when XeSS is provided by Proton Oct 19, 2026
@damian-tomczak-intel

Copy link
Copy Markdown
Contributor Author

This is one of four [XeSS XMX] PRs that together add XMX-accelerated XeSS to Proton:

The Proton PR bumps the other three submodules, so it should go in last.

Comment thread src/dxgi/dxgi_adapter.cpp Resolved
Comment thread src/dxgi/dxgi_options.cpp Resolved
Comment thread src/dxgi/dxgi_options.cpp
// doesn't use the Intel path that needs the workaround.
static const char builtinSignature[] = "Wine builtin DLL";
bool isBuiltin = !std::memcmp(reinterpret_cast<const char*>(libxess) + 0x40,
builtinSignature, sizeof(builtinSignature));

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a more robust way to detect this (e.g. some export that's only available in the built-in dll or something)?

This hack looks like the kind of thing that's just going to blow up either on Windows or at some point in the future, and when it does then the only real option is to remove the code.

Comment thread src/dxgi/dxgi_options.h Outdated

private:

mutable std::atomic<XessVendorWa> m_xessVendorWa = { XessVendorWa::Unknown };

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this just be a static variable inside the respective function or do we ever expect to have to do the workaround in one DXGI factory but not the other?

ccallawa-intel and others added 6 commits November 17, 2026 10:57
File version Windows API calls fail on the DLL
intercept, and Proton-shipped XeSS library must be
compatible with Linux environs.
Evaluate the XeSS Intel vendor workaround when adapters are enumerated rather than when DXGI options are constructed, since applications may load libxess.dll after startup. Cache a positive decision so later adapter queries remain consistent without repeatedly probing the module. Keep Intel visible when XeSS is absent or the configured library is known-good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants